Skip to content

ADHOC: update the contribution templates to include a note on results #15450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dmanners
Copy link
Contributor

Description

As a continuation of #15387 I have updated the issue template to include the following [Screenshots, logs or description] to the Actual and Expected results section. Thank you @sriesterer for the feedback on these documents.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…nd expected results

 - Making it so that screenshots and logs are optional
@magento-engcom-team
Copy link
Contributor

Hi @dmanners. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants